-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a configuration option on how to label PCR data #662
Conversation
...tension.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/swt/ExtendedPlateChartsUI.java
Outdated
Show resolved
Hide resolved
...n.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/preferences/PreferenceConstants.java
Outdated
Show resolved
Hide resolved
...tension.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/swt/ExtendedPlateChartsUI.java
Outdated
Show resolved
Hide resolved
Updated. |
What happens if
the return of |
private String getString(Properties p, String name) {
String value = p != null ? p.getProperty(name) : null;
if (value == null) {
return STRING_DEFAULT_DEFAULT;
}
return value;
} will never return null. I now also set the ID of line series and use the description field instead. |
Looks good. Two comments: A) When introducing a new dependency, I recommend to also set the required version in the MANIFEST.MF: B) I recommend to use as less dependencies as possible. In this case, Google Enums is not necessarily needed. You could rewrite the code in the following way, which is also more compact:
|
Rebased, removed Google Guave, initialized the setting and put the settings button on the right. |
Closes #661